Added Manager, Contributor targeted logic and collapsible filters #3655
Conversation
Codecov ReportAttention: Patch coverage is
🚀 New features to boost your workflow:
|
Please make sure you use the right keyword to link to the corresponding issue. :) Looks like the Locales and Projects sections always appear on the review page: they shouldn't if Locales / Projects Filters are not used. Also, in the event that no projects/locales are selected (but the filter is used / expanded), the number of recipients should be zero. At the very end, I'd like to commit minor CSS changes. I think we'll need to use checkboxes instead of arrows to make it clearer when the filter is used. Then we'll also need to update the docs. |
|
Please also reference #3431 in the first comment if the intention is to fix that issue, too. Relatedly, if I don't enable filtering by locale and project, and target all 3 user roles, I'd expect all users to be recipients of the message. But the count for me locally reads 6,766, while there are 23098 user accounts. If I select all locales and all projects, the recipient count is 6,069. |
|
Hmm that is very strange |
This commit adds collapsible filters to the messaging center, removes the minimum project/locale form requirements, changes the query logic and alters the form both in visuals and core logic.
This commit adds checkboxes instead of a dropdown for filters. It changes many styles. It edits the logic for filtering recipients and adds multiple form fields.
e16e912 to
aa989df
Compare
This commit resolves #3453 and #3431. One should now be able to singly target managers, translators and contributors of a specific project, and also singly target likewise of a specific locale. Furthermore, it adds collapsible filters to the messaging center, removes the minimum project/locale form requirements, changes the query logic and alters the form both in visuals and core logic.